Copilot commented on code in PR #7630:
URL: https://github.com/apache/ignite-3/pull/7630#discussion_r2827161936
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItRecordBinaryViewApiTest.java:
##########
@@ -328,7 +345,7 @@ public void validateSchema(BinTestCase testCase) {
RecordView<Tuple> tbl = testCase.view();
- Tuple keyTuple0 = Tuple.create().set("id", 0).set("id1", 0);
+ Tuple keyTuple0 = Tuple.create().set("id",
Double.MAX_VALUE).set("id1", 0);
Review Comment:
This change from `0` to `Double.MAX_VALUE` appears unrelated to the type
casting feature being implemented. The purpose of this change is unclear and
could potentially be a mistake or an unintentional side-effect during testing.
If this is intentional, please clarify why this specific value was chosen for
this test case.
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItKeyValueBinaryViewApiTest.java:
##########
@@ -682,7 +1105,7 @@ void checkInvalidTypeError(Executable run, String
expectedMessage) {
}
void checkValueTypeDoesNotMatchError(Executable run) {
- String expectedMessage = "Value type does not match [column='ID',
expected=INT64, actual=INT32]";
+ String expectedMessage = "Value type does not match [column='ID',
expected=INT64, actual=DOUBLE]";
Review Comment:
Similar to the change in `ItRecordBinaryViewApiTest`, the expected message
is being changed from "actual=INT32" to "actual=DOUBLE", which indicates that
the test is now passing a Double value instead of an Integer. This change
directly relates to the modification on line 461 where the value was changed
from `0` to `0.0d`. These changes appear to be testing the new type casting
behavior, but the test name `checkValueTypeDoesNotMatchError` suggests it
should test type mismatch errors. Please verify that this test is still
validating the correct behavior.
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItKeyValueBinaryViewApiTest.java:
##########
@@ -441,7 +458,7 @@ public void replaceExact(TestCase testCase) {
public void validateSchema(TestCase testCase) {
KeyValueView<Tuple, Tuple> tbl = testCase.view();
- Tuple keyTuple0 = Tuple.create().set("id", 0).set("id1", 0);
+ Tuple keyTuple0 = Tuple.create().set("id", 0.0d).set("id1", 0);
Review Comment:
This change from `0` to `0.0d` appears unrelated to the type casting feature
being implemented. The purpose of this change is unclear and could potentially
be a mistake or an unintentional side-effect during testing. If this is
intentional, please clarify why this specific value was changed for this test
case.
##########
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItRecordBinaryViewApiTest.java:
##########
@@ -891,7 +1320,7 @@ static class BinTestCase extends TestCase<Tuple> {
}
void checkValueTypeDoesNotMatchError(Executable run) {
- String expectedMessage = "Value type does not match [column='ID',
expected=INT64, actual=INT32]";
+ String expectedMessage = "Value type does not match [column='ID',
expected=INT64, actual=DOUBLE]";
Review Comment:
The expected message is being changed from "actual=INT32" to
"actual=DOUBLE", which indicates that the test is now passing a Double value
instead of an Integer. This change directly relates to the modification on line
348 where the value was changed from `0` to `Double.MAX_VALUE`. These changes
appear to be testing the new type casting behavior, but the test name
`checkValueTypeDoesNotMatchError` suggests it should test type mismatch errors,
not successful type conversions. Please verify that this test is still
validating the correct behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
