AMashenkov commented on code in PR #7630:
URL: https://github.com/apache/ignite-3/pull/7630#discussion_r2827026198


##########
modules/api/src/main/java/org/apache/ignite/table/Tuple.java:
##########
@@ -280,6 +280,14 @@ static boolean equals(Tuple firstTuple, Tuple secondTuple) 
{
     /**
      * Gets a {@code byte} column value.
      *
+     * <p>Implicit conversions:
+     * <ul>
+     *   <li>{@link Byte} - returned directly;</li>
+     *   <li>{@link Short}, {@link Integer}, {@link Long} - accepted only if 
the numeric value fits into
+     *       {@code byte} range (otherwise {@link ArithmeticException} is 
thrown);</li>
+     *   <li>other types cause {@link ClassCastException}.</li>
+     * </ul>

Review Comment:
   ```suggested
   * <p>Implicit conversions: column values of {@link Short}, {@link Integer} 
or {@link Long} types are silently converted to a {@code byte} 
   * if the value fit {@code byte} range, otherwise {@link ArithmeticException} 
is thrown.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to