rpuch commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2781861066
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -283,7 +278,7 @@ public CompletableFuture<NetworkMessage> invoke(String
recipientConsistentId, Ch
InternalClusterNode recipient =
topologyService.getByConsistentId(recipientConsistentId);
if (recipient == null) {
- metrics.incrementInvokeRequestFailures();
+ metrics.incrementRequestSendingFailures();
Review Comment:
Should it be `metrics.incrementMessageRecipientNotFound();`?
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -362,7 +355,7 @@ private CompletableFuture<NetworkMessage> invoke0(
boolean strictIdCheck
) {
if (connectionManager.isStopped()) {
- metrics.incrementInvokeRequestFailures();
+ metrics.incrementRequestSendingFailures();
Review Comment:
Should we increment any metrics if we refuse to send due to a legitimate
reason (node stopping in this case)? Also, it doesn't look consistently: in
`send0()` we don't increment anything, but here we do
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -549,7 +538,7 @@ private void handleMessageFromNetwork(InNetworkObject
inNetworkObject) {
try {
handleStartingWithFirstHandler(payload, finalCorrelationId,
inNetworkObject, firstHandlerContext, handlerContexts);
} catch (Throwable e) {
- metrics.incrementInvokeResponseFailures();
+ metrics.incrementResponseSendingFailures();
Review Comment:
`handleStartingWithFirstHandler()` applies handlers to the incoming message,
so it's something like 'messageHandlingErrors', it's not about responses or
sending
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MessagingServiceMetrics.java:
##########
@@ -49,31 +43,16 @@ class DefaultMessagingServiceMetrics {
"Total number of message recipient resolution failures."
));
- invokeRequestFailures = source.addMetric(new AtomicLongMetric(
- "invokeRequestFailures",
+ requestSendingFailures = source.addMetric(new AtomicLongMetric(
+ "requestSendingFailures",
Review Comment:
How is this different from `messageTransmitFailures`? I'm reading the
descriptions and they seem to be about the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
