adityamukho commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2781090795
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -390,13 +420,17 @@ private CompletableFuture<Void> sendViaNetwork(
try {
descriptors = prepareMarshal(message);
} catch (Exception e) {
+ metrics.incrementMessageSerializationFailures();
+
return failedFuture(new IgniteException(INTERNAL_ERR, "Failed to
marshal message: " + e.getMessage(), e));
}
return connectionManager.channel(nodeId, type, addr)
.thenComposeToCompletable(sender -> {
if (strictIdCheck && nodeId != null &&
!sender.launchId().equals(nodeId)) {
// The destination node has been rebooted, so it's a
different node instance.
+ metrics.incrementMessageSendFailures();
Review Comment:
Replaced with more generic `messageTransmitFailures`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
