ivanzlenko commented on code in PR #6549:
URL: https://github.com/apache/ignite-3/pull/6549#discussion_r2321960775
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -1690,23 +1692,28 @@ private void checkSelfInTopology(
private RuntimeException handleStartException(Throwable e) {
String errMsg = "Unable to start [node=" + name + "]";
-
var igniteException = new IgniteException(extractCodeFrom(e), errMsg,
e);
- // We log the exception as soon as possible to minimize the
probability that it gets lost due to something like an OOM later.
- LOG.error(errMsg, igniteException);
+ var rootEx = unwrapRootCause(e);
Review Comment:
You can check what exact type returned by the method only after visiting
said method.
var should be used only in the cases where you do not need to do that.
Slava pointed to our check style in regards to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
