ibessonov commented on code in PR #6377:
URL: https://github.com/apache/ignite-3/pull/6377#discussion_r2260438069
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/comparator/JitComparatorGenerator.java:
##########
@@ -433,11 +483,32 @@ private static MethodDefinition innerCompare(
body.append(endOfBlockLabel);
- body.append(outerEntryBaseStart.set(outerEntryBaseEnd));
- body.append(innerEntryBaseStart.set(innerEntryBaseEnd));
+ if (!lastIteration) {
+ body.append(outerEntryBaseStart.set(outerEntryBaseEnd));
+ body.append(innerEntryBaseStart.set(innerEntryBaseEnd));
+ }
+ }
+
+ if (options.supportPrefixes()) {
+ // If prefixes are supported, we must always check what column
we compare,
+ // and return a corresponding value if it was the last column
in the prefix.
+ BytecodeExpression outerFlagExpression =
outerAccessor.invoke("get", byte.class, constantInt(0)).cast(int.class);
Review Comment:
Fair question. Honestly - I didn't want to pass them as a sixth parameter of
"internal compare" method. This operation is very rare, I'd prefer code
simplicity to the maximal performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
