ibessonov commented on code in PR #6377:
URL: https://github.com/apache/ignite-3/pull/6377#discussion_r2260434796
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/comparator/JitComparatorGenerator.java:
##########
@@ -390,18 +440,18 @@ private static MethodDefinition innerCompare(
)));
}
- CatalogColumnCollation collation = columnCollations.get(i);
- NativeType columnType = columnTypes.get(i);
+ CatalogColumnCollation collation =
options.columnCollations().get(i);
+ NativeType columnType = options.columnTypes().get(i);
// Nullability check.
- if (nullableFlags.get(i)) {
+ if (options.nullableFlags().get(i)) {
body.append(outerInNull.set(equal(outerEntryBaseStart,
outerEntryBaseEnd)));
body.append(innerInNull.set(equal(innerEntryBaseStart,
innerEntryBaseEnd)));
// Usage of "bitwiseAnd" and "bitwiseOr" make generated code
easier to read when decompiled.
body.append(new IfStatement()
.condition(bitwiseAnd(outerInNull, innerInNull))
- .ifTrue(lastIteration ? constantInt(0).ret() :
jump(endOfBlockLabel))
+ .ifTrue(lastIteration && !options.supportPrefixes() ?
constantInt(0).ret() : jump(endOfBlockLabel)) // <-------
Review Comment:
Forgot to remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
