isapego commented on code in PR #6361:
URL: https://github.com/apache/ignite-3/pull/6361#discussion_r2254145505


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -764,7 +764,8 @@ private CompletableFuture<ResponseWriter> processOperation(
             ClientMessageUnpacker in,
             int opCode,
             long requestId,
-            HybridTimestampTracker tsTracker
+            HybridTimestampTracker tsTracker,
+            String remoteAddress

Review Comment:
   This should probably go to `ClientContext`



##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -897,8 +898,15 @@ private CompletableFuture<ResponseWriter> processOperation(
                         clientContext.hasFeature(TX_PIGGYBACK));
 
             case ClientOp.COMPUTE_EXECUTE:
-                return ClientComputeExecuteRequest.process(in, compute, 
clusterService, notificationSender(requestId),
-                        clientContext.hasFeature(PLATFORM_COMPUTE_JOB));
+                return ClientComputeExecuteRequest.process(
+                        in,
+                        compute,
+                        clusterService,
+                        notificationSender(requestId),
+                        clientContext.hasFeature(PLATFORM_COMPUTE_JOB),
+                        remoteAddress,
+                        clientContext.userDetails()

Review Comment:
   Let's add remoteAddress to `ClientContext` and just pass `clientContext` to 
request here and below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to