Re: [PR] IGNITE-26115 Create compute task events for thin client [ignite-3]

[via GitHub]

Copilot commented on code in PR #6361:
URL: https://github.com/apache/ignite-3/pull/6361#discussion_r2254140418


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/compute/ClientComputeExecutePartitionedRequest.java:
##########
@@ -55,21 +60,28 @@ public static CompletableFuture<ResponseWriter> process(
             IgniteTables tables,
             ClusterService cluster,
             NotificationSender notificationSender,
-            boolean enablePlatformJobs
+            boolean enablePlatformJobs,
+            String remoteAddress,
+            UserDetails userDetails
     ) {
         int tableId = in.unpackInt();
         int partitionId = in.unpackInt();
 
         Job job = ClientComputeJobUnpacker.unpackJob(in, enablePlatformJobs);
 
         return readTableAsync(tableId, tables).thenCompose(table -> {
+            Builder metadataBuilder = 
ComputeEventMetadata.builder(Type.BROADCAST)

Review Comment:
   The event type should be Type.PARTITIONED instead of Type.BROADCAST for 
partitioned compute operations. BROADCAST suggests the operation runs on all 
nodes, while this is a partitioned operation running on a specific partition.
   ```suggestion
               Builder metadataBuilder = 
ComputeEventMetadata.builder(Type.PARTITIONED)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org