korlov42 commented on code in PR #6314: URL: https://github.com/apache/ignite-3/pull/6314#discussion_r2247220011
########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionContext.java: ########## @@ -152,6 +156,7 @@ public ExecutionContext( this.txAttributes = txAttributes; this.timeZoneId = timeZoneId; this.inBufSize = inBufSize < 0 ? Commons.IN_BUFFER_SIZE : inBufSize; + this.currentUser = username == null ? Commons.SYSTEM_USER_NAME : username; Review Comment: I think, the user must be known by this point, hence from execution point of view it never null. The better place to make decision is somewhere prior to call to queryExecutor. We might expose information about user in SQL_QUERIES view, and user must be unambiguously resolved to avoid discrepancies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org