korlov42 commented on code in PR #6314:
URL: https://github.com/apache/ignite-3/pull/6314#discussion_r2239560912
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/QueryExecutor.java:
##########
@@ -176,6 +177,10 @@ public CompletableFuture<AsyncSqlCursor<InternalSqlRow>>
executeQuery(
@Nullable CancellationToken cancellationToken,
Object... params
) {
+ if (properties.userName() == null) {
+ properties.userName(Commons.SYSTEM_USER_NAME);
Review Comment:
`SqlProperties` is an input parameter of
`org.apache.ignite.internal.sql.engine.QueryProcessor#queryAsync`. It's 1)
supposed to be reusable and 2) not thread safe. We must not modify this inside
query engine
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlOperationContext.java:
##########
@@ -104,6 +107,10 @@ public ZoneId timeZoneId() {
return timeZoneId;
}
+ public @Nullable String userName() {
Review Comment:
please add the javadoc describing what does this parameter mean and when it
expected to be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
