xtern commented on code in PR #6274:
URL: https://github.com/apache/ignite-3/pull/6274#discussion_r2230342452
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -362,8 +363,33 @@ public static BigDecimal toBigDecimal(Number value, int
precision, int scale) {
}
}
+ /** Adjusts precision of {@link SqlTypeName#TIME} value. */
+ public static @Nullable Integer toTimeExact(@Nullable Object object, int
precision) {
+ if (object == null) {
+ return null;
+ }
+
+ assert object instanceof Integer : object.getClass();
+
+ return toTimeExact((int) object, precision);
+ }
+
+ /** Adjusts precision of {@link SqlTypeName#TIME} value. */
+ public static int toTimeExact(int val, int precision) {
+ assert precision >= 0 : "Invalid precision: " + precision;
+
+ return IgniteSqlDateTimeUtils.adjustTimeMillis(val, precision);
+ }
+
+ /** Adjusts precision of {@link SqlTypeName#TIME} value. */
+ public static int toTimeExact(long val, int precision) {
Review Comment:
Thanks, now we have such tests
See `temporalPrecisionLookupDynParamArgs` test cases with explicit dyn param
cast e.g. ` = ?::TIME(X)`
If we skip conversion of dyn param value in
RexToLuxTranslator#visitDynamicParam then the value remains unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
