zstan commented on code in PR #6274: URL: https://github.com/apache/ignite-3/pull/6274#discussion_r2224427255
########## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItTemporalIndexTest.java: ########## @@ -158,6 +181,27 @@ public void testSearchGtLtWithPkIdxUsage(String table, String predicate, Object } } + /** Check range predicates with dynamic parameter. */ + @ParameterizedTest(name = "table = {0}, predicate = {1}") + @MethodSource("geLeSearchDynParamArguments") + public void testSearchGtLtWithPkIdxUsageDynamicParam(String table, String predicate, Object parameter, Object result) { + assertQuery(format("SELECT /*+ FORCE_INDEX({}), DISABLE_RULE('TableScanToKeyValueGetRule') */ val FROM {} WHERE pk {} ORDER BY val", Review Comment: involved predicates can not match TableScanToKeyValueGetRule usage, thus it need to be removed if EQ predicates are not planned to use, otherwise it confused. Or probably it more clear to extend SORTED_INDEXES with "pkIndexName(table)" wdyt ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org