ibessonov commented on code in PR #6023:
URL: https://github.com/apache/ignite-3/pull/6023#discussion_r2219196356
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/ManualGroupRestartRequestSerializer.java:
##########
@@ -59,14 +59,26 @@ protected ManualGroupRestartRequest readExternalData(byte
protoVer, IgniteDataIn
Set<String> nodeNames = readStringSet(in);
HybridTimestamp assignmentsTimestamp = HybridTimestamp.readFrom(in);
+ if (protoVer > 2) {
+ return new ManualGroupRestartRequest(
Review Comment:
You don't have to duplicate the code. Instead, you could have written
```
boolean cleanUp = false;
if (protoVer > 2) {
cleanUp = in.readBoolean();
}
return new ManualGroupRestartRequest...
```
Offtopic: in AI2 we have constants like `V2`, I believe, I wish we had them
here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
