alievmirza commented on code in PR #6023:
URL: https://github.com/apache/ignite-3/pull/6023#discussion_r2219150139


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/ManualGroupRestartRequest.java:
##########
@@ -99,6 +124,20 @@ public CompletableFuture<Void> 
handle(DisasterRecoveryManager disasterRecoveryMa
 
         var restartFutures = new ArrayList<CompletableFuture<?>>();
 
+        if (cleanUp) {
+            restartPartitionWithCleanup(disasterRecoveryManager, revision, 
timestamp, restartFutures);
+        } else {
+            restartPartition(disasterRecoveryManager, revision, 
restartFutures);
+        }
+
+        return restartFutures.isEmpty() ? nullCompletedFuture() : 
allOf(restartFutures.toArray(CompletableFuture[]::new));

Review Comment:
   I didn’t quite understand exactly what you want in this ticket? 



##########
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -710,6 +710,8 @@ public static class DisasterRecovery {
 
         /** Error while returning partition states. */
         public static final int CLUSTER_NOT_IDLE_ERR = 
RECOVERY_ERR_GROUP.registerErrorCode((short) 4);
+
+        public static final int RESTART_WITH_CLEAN_UP_ERR = 
RECOVERY_ERR_GROUP.registerErrorCode((short) 5);

Review Comment:
   added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to