korlov42 commented on code in PR #6128:
URL: https://github.com/apache/ignite-3/pull/6128#discussion_r2176665797
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexToLixTranslator.java:
##########
@@ -1027,6 +1195,9 @@ public static Expression translateLiteral(
case VARCHAR:
value2 = literal.getValueAs(String.class);
break;
+ case UUID:
Review Comment:
I believe old approach is mush better than this one.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlParserSelfTest.java:
##########
@@ -96,7 +96,7 @@ public void
testGrammarViolationButExceptionIsReplacedInsideParser() {
@Test
public void testEmptyString() {
assertThrowsSqlException(Sql.STMT_PARSE_ERR,
- "Failed to parse query: Encountered \"<EOF>\" at line 0,
column 0",
+ "Failed to parse query: No statements",
Review Comment:
nitpick: `Not a statement` sounds better to me. But feel free to ignore this
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
