zstan commented on code in PR #6128:
URL: https://github.com/apache/ignite-3/pull/6128#discussion_r2176553669
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/Commons.java:
##########
@@ -809,4 +811,22 @@ public static boolean
isMultiStatementQueryAllowed(SqlProperties properties) {
return firstFoundError;
}
+
+ /**
+ * Creates a {@link JoinInfo join condition} that treats {@code IS NOT
DISTINCT FROM} as an equijoin condition.
+ *
+ * @param join Logical join.
+ * @return Join condition.
+ */
+ public static JoinInfo getNonStrictEquiJoinCondition(LogicalJoin join) {
+ JoinInfo joinInfo = join.analyzeCondition();
+
+ // Already an equijoin condition, do nothing.
+ if (joinInfo.isEqui()) {
+ return joinInfo;
+ }
+
+ // Create a non-strict equijoin condition that treats IS NOT
DISTINCT_FROM as an equi join condition.
+ return JoinInfo.of(join.getLeft(), join.getRight(),
join.getCondition());
Review Comment:
probably it become more accurate to change a bit
_Commons.getNonStrictEquiJoinCondition_ semantic and rewrite all above like:
this.joinInfo = Commons.getNonStrictEquiJoinCondition(this);
wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
