ivanzlenko commented on code in PR #6093:
URL: https://github.com/apache/ignite-3/pull/6093#discussion_r2163590686
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##########
@@ -107,21 +107,21 @@ public class MulticastNodeFinder implements NodeFinder {
* @param resultWaitMillis Wait time for responses.
* @param ttl Time-to-live for multicast packets.
* @param nodeName Node name.
- * @param localAddressToAdvertise Local node address.
+ * @param addressesToAdvertise Local node addresses.
*/
public MulticastNodeFinder(
String multicastGroup,
int multicastPort,
int resultWaitMillis,
int ttl,
String nodeName,
- InetSocketAddress localAddressToAdvertise
+ Collection<NetworkAddress> addressesToAdvertise
Review Comment:
No point to have Collection here as well
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##########
@@ -198,9 +198,10 @@ private void waitForResponses(byte[] responseBuffer,
MulticastSocket socket, Set
try {
byte[] data = receiveDatagramData(socket, responsePacket);
- InetSocketAddress address = ByteUtils.fromBytes(data);
- if (!address.equals(localAddressToAdvertise)) {
- discovered.add(NetworkAddress.from(address));
+ Collection<NetworkAddress> addresses =
NetworkAddressesSerializer.deserialize(data);
Review Comment:
Thanks for explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
