Phillippko commented on code in PR #6093:
URL: https://github.com/apache/ignite-3/pull/6093#discussion_r2161482263
##########
modules/network/src/main/java/org/apache/ignite/internal/network/MulticastNodeFinder.java:
##########
@@ -198,9 +198,10 @@ private void waitForResponses(byte[] responseBuffer,
MulticastSocket socket, Set
try {
byte[] data = receiveDatagramData(socket, responsePacket);
- InetSocketAddress address = ByteUtils.fromBytes(data);
- if (!address.equals(localAddressToAdvertise)) {
- discovered.add(NetworkAddress.from(address));
+ Collection<NetworkAddress> addresses =
NetworkAddressesSerializer.deserialize(data);
Review Comment:
First address is used only to check if response was sent from the local node
- there is no need to check every address
Node sends all addresses that it listens to. And here we read a collection
of the addresses, not only first one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
