sashapolo commented on code in PR #6089:
URL: https://github.com/apache/ignite-3/pull/6089#discussion_r2160002990
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/NodePropertiesImpl.java:
##########
@@ -105,4 +108,9 @@ public boolean colocationEnabled() {
public CompletableFuture<Void> stopAsync(ComponentContext
componentContext) {
return nullCompletedFuture();
}
+
+ @Override
+ public Map<String, String> nodeAttributes() {
+ return Map.of(COLOCATION_FEATURE_FLAG,
Boolean.toString(colocationEnabled()));
Review Comment:
How does it make the solution more consistent? It's a constant that is
located in IgniteSystemProperties (which is for system properties), and here it
is a key in the map. I'm ok with it having the same string value, but I think a
separate constant would be more clear, because these two keys have a different
semantical value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
