sanpwc commented on code in PR #6089:
URL: https://github.com/apache/ignite-3/pull/6089#discussion_r2160004356


##########
modules/runner/src/main/java/org/apache/ignite/internal/app/NodePropertiesImpl.java:
##########
@@ -105,4 +108,9 @@ public boolean colocationEnabled() {
     public CompletableFuture<Void> stopAsync(ComponentContext 
componentContext) {
         return nullCompletedFuture();
     }
+
+    @Override
+    public Map<String, String> nodeAttributes() {
+        return Map.of(COLOCATION_FEATURE_FLAG, 
Boolean.toString(colocationEnabled()));

Review Comment:
   > How does it make the solution more consistent?
   
   Because it's the projection of the corresponding IgniteSystemProperties 
constant or the value from the vault. It's literary node local value of 
colocation feature flag.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to