isapego commented on code in PR #6002:
URL: https://github.com/apache/ignite-3/pull/6002#discussion_r2137377080
##########
modules/platforms/cpp/ignite/client/ignite_client.cpp:
##########
@@ -21,22 +21,28 @@
#include <ignite/common/ignite_error.h>
-#include <thread>
+#include "detail/argument_check_utils.h"
namespace ignite {
void ignite_client::start_async(ignite_client_configuration configuration,
std::chrono::milliseconds timeout,
ignite_callback<ignite_client> callback) {
// TODO: IGNITE-17762 Async start should not require starting thread
internally. Replace with async timer.
- auto res = std::async([cfg = std::move(configuration), timeout, callback =
std::move(callback)]() mutable {
+ auto fut = std::async([cfg = std::move(configuration), timeout, callback =
std::move(callback)]() mutable {
auto res =
result_of_operation<ignite_client>([cfg = std::move(cfg),
timeout]() { return start(cfg, timeout); });
callback(std::move(res));
});
- UNUSED_VALUE res;
+ UNUSED_VALUE fut;
}
ignite_client ignite_client::start(ignite_client_configuration configuration,
std::chrono::milliseconds timeout) {
+ detail::arg_check::container_non_empty(configuration.get_endpoints(),
"Connection endpoint list");
+
+ if (configuration.get_heartbeat_interval().count() < 0) {
+ throw ignite_error(error::code::ILLEGAL_ARGUMENT, "Heartbeat interval
can not be negative");
Review Comment:
It means heartbeats are disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
