isapego commented on code in PR #6002:
URL: https://github.com/apache/ignite-3/pull/6002#discussion_r2137394273
##########
modules/platforms/cpp/ignite/client/ignite_client_configuration.h:
##########
@@ -132,14 +138,41 @@ class ignite_client_configuration {
[[nodiscard]] uint32_t get_connection_limit() const { return
m_connection_limit; }
/**
- * Set connection limit.
+ * Set the connection limit.
*
- * @see GetConnectionsLimit for details.
+ * @see get_connections_limit for details.
*
* @param limit Connections limit to set.
*/
void set_connection_limit(uint32_t limit) { m_connection_limit = limit; }
+ /**
+ * Get a heartbeat interval.
+ * When server-side idle timeout is not zero, the effective heartbeat
interval is set to
+ * min(heartbeat_interval, idle_timeout / 3)
+ *
+ * When thin client connection is idle (no operations are performed),
heartbeat messages are sent periodically
+ * to keep the connection alive and detect potential half-open state.
+ *
+ * Zero value means heartbeats are disabled.
+ *
+ * The default value is DEFAULT_HEARTBEAT_INTERVAL.
+ *
+ * @return Heartbeat interval.
+ */
+ [[nodiscard]] std::chrono::microseconds get_heartbeat_interval() const {
return m_heartbeat_interval; }
+
+ /**
+ * Set a heartbeat interval.
+ *
+ * @see get_heartbeat_interval for details.
+ *
+ * @param heartbeat_interval Heartbeat interval.
+ */
+ void set_heartbeat_interval(std::chrono::microseconds heartbeat_interval) {
+ m_heartbeat_interval = heartbeat_interval;
Review Comment:
Makes sense, but with the current approach all configuration parameters are
verified on client side. I've added a ticket to move all the checks to
configuration: https://issues.apache.org/jira/browse/IGNITE-25631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
