sergey-chugunov-1985 commented on code in PR #12110:
URL: https://github.com/apache/ignite/pull/12110#discussion_r2122959096
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/version/GridCacheRawVersionedEntry.java:
##########
@@ -308,17 +305,11 @@ public void prepareDirectMarshal(CacheObjectContext ctx)
throws IgniteCheckedExc
}
- assert key != null;
Review Comment:
My point here is that I want to describe explicitly the fact that message
itself knows nothing about semantics of its fields and what are possible values
for the fields. So enforsing rules like "when this field is null that field
should be positive" is not a responsibility of a message itself but of a code
that uses (consumes) the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
