timoninmaxim commented on code in PR #12110:
URL: https://github.com/apache/ignite/pull/12110#discussion_r2121605624
##########
modules/core/src/main/java/org/apache/ignite/plugin/extensions/communication/MessageReader.java:
##########
@@ -39,246 +39,198 @@ public interface MessageReader {
*/
public void setBuffer(ByteBuffer buf);
- /**
- * Sets type of message currently read.
- *
- * @param msgCls Message type.
- */
- public void setCurrentReadClass(Class<? extends Message> msgCls);
-
- /**
- * Callback that must be invoked by a message implementation before
message body started decoding.
- *
- * @return {@code True} if reading can proceed, {@code false} otherwise.
- */
- public boolean beforeMessageRead();
-
- /**
- * Callback that must be invoked by a message implementation after message
body finished decoding.
- *
- * @param msgCls Message class finishing read stage.
- * @return {@code True} if reading can proceed, {@code false} otherwise.
- */
- public boolean afterMessageRead(Class<? extends Message> msgCls);
-
/**
* Reads {@code byte} value.
*
- * @param name Field name.
* @return {@code byte} value.
*/
- public byte readByte(String name);
+ public byte readByte();
/**
* Reads {@code short} value.
*
- * @param name Field name.
* @return {@code short} value.
*/
- public short readShort(String name);
+ public short readShort();
/**
* Reads {@code int} value.
*
- * @param name Field name.
* @return {@code int} value.
*/
- public int readInt(String name);
+ public int readInt();
/**
* Reads {@code int} value.
*
- * @param name Field name.
* @param dflt Default value if field not found.
* @return {@code int} value.
*/
- public int readInt(String name, int dflt);
+ public int readInt(int dflt);
Review Comment:
I'll remove this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
