shishkovilja commented on code in PR #12017:
URL: https://github.com/apache/ignite/pull/12017#discussion_r2108302012
##########
modules/commons/src/main/java/org/apache/ignite/internal/util/CommonUtils.java:
##########
@@ -21,12 +21,13 @@
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.util.typedef.F;
import org.jetbrains.annotations.Nullable;
/**
* Collection of utility methods used in 'ignite-commons' and throughout the
system.
*/
-public abstract class CommonUtils {
+public class CommonUtils {
Review Comment:
Unnecessary edit
##########
modules/direct-io/pom.xml:
##########
@@ -42,6 +42,18 @@
<artifactId>ignite-core</artifactId>
</dependency>
+ <dependency>
Review Comment:
Move it to separate PR
##########
modules/compress/pom.xml:
##########
@@ -41,6 +41,18 @@
<artifactId>ignite-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>ignite-commons</artifactId>
Review Comment:
If it is necessary, but compilation does not fail currently, let s put it to
separate pull request.
##########
modules/compatibility/pom.xml:
##########
@@ -46,6 +46,13 @@
<artifactId>ignite-core</artifactId>
</dependency>
+ <dependency>
Review Comment:
Let's put it into separate pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
