maksaska commented on code in PR #12017:
URL: https://github.com/apache/ignite/pull/12017#discussion_r2106164165
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/testframework/junits/SkipTestIfJdkNewerRule.java:
##########
@@ -25,7 +25,7 @@
/** */
public class SkipTestIfJdkNewerRule implements TestRule {
/** */
- private static final String jdkVersion = U.jdkVersion();
+ private static final String jdkVersion = CommonUtils.jdkVersion();
Review Comment:
Fixed
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/testframework/junits/SkipTestIfJdkNewerRule.java:
##########
@@ -36,7 +36,7 @@ public class SkipTestIfJdkNewerRule implements TestRule {
if (ann == null)
ann =
desc.getTestClass().getAnnotation(SkipTestIfIsJdkNewer.class);
- Assume.assumeTrue("Skipping test", ann == null ||
U.majorJavaVersion(jdkVersion) <= ann.value());
+ Assume.assumeTrue("Skipping test", ann == null ||
CommonUtils.majorJavaVersion(jdkVersion) <= ann.value());
Review Comment:
Fixed
##########
modules/compress/pom.xml:
##########
@@ -41,6 +41,19 @@
<artifactId>ignite-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>ignite-commons</artifactId>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>ignite-grid-unsafe</artifactId>
+ <version>${revision}</version>
Review Comment:
Fixed
##########
modules/control-utility/pom.xml:
##########
@@ -47,6 +47,13 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>${project.groupId}</groupId>
+ <artifactId>ignite-grid-unsafe</artifactId>
+ <version>${revision}</version>
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
