vadimkolodingg commented on code in PR #5825:
URL: https://github.com/apache/ignite-3/pull/5825#discussion_r2097763459
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java:
##########
@@ -308,13 +309,56 @@ private void doStableKeySwitch(
Entry switchAppendEntry = values.get(switchAppendKey);
Entry assignmentsChainEntry = values.get(assignmentsChainKey);
+ AssignmentsQueue pendingAssignmentsQueue =
AssignmentsQueue.fromBytes(pendingEntry.value());
Review Comment:
unfortuantely, added lines use quick return and recursion, which limits ways
to refactor.
For me, it's more clear leaving those lines as is than adding method with a
bunch of arguments (which is just single `metaStorageMgr.invoke`)
```java
boolean updated = pendingAssignmentsPollAndUpdate(metaStorageMgr,
pendingKey, revision, stable, pendingQueue)
if (updated) {
return;
} else {
doStableKeySwitch(...)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
