vadimkolodingg commented on code in PR #5825:
URL: https://github.com/apache/ignite-3/pull/5825#discussion_r2097745713
##########
modules/partition-distribution/src/main/java/org/apache/ignite/internal/partitiondistribution/PendingAssignmentsCalculator.java:
##########
@@ -49,15 +53,79 @@ public PendingAssignmentsCalculator target(Assignments
target) {
}
/**
- * Calculates the pending assignments queue between current stable and
target assignments.
+ * Calculates the pending assignments queue between current stable (not
included) and target assignments (included, last element).
*/
public AssignmentsQueue toQueue() {
assert stable != null;
assert target != null;
Review Comment:
calculator is made like builder, and it is not possible to make those fields
final. I don't want to change builder to public constructor or make fields
`final AtomicReference`
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java:
##########
@@ -64,6 +64,7 @@
import org.apache.ignite.internal.partitiondistribution.Assignments;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
