alievmirza commented on code in PR #5726: URL: https://github.com/apache/ignite-3/pull/5726#discussion_r2068658633
########## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ########## @@ -1190,6 +1211,16 @@ private CompletableFuture<Void> handleChangePendingAssignmentEvent(Entry pending return nullCompletedFuture(); } + // A node might exist in stable yet we don't want to start the replica Review Comment: In table manager we have only one place where we use logic like this: ``` if (isRecovery && !replicaMgr.isReplicaStarted(replicaGrpId)) { return; } ``` Why in colocation logic we have two places? What is the reason? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org