Cyrill commented on code in PR #5726:
URL: https://github.com/apache/ignite-3/pull/5726#discussion_r2068649845
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java:
##########
@@ -599,11 +599,37 @@ public static List<Assignments> zoneAssignmentsGetLocally(
) {
return IntStream.range(0, numberOfPartitions)
.mapToObj(p -> {
- Entry e =
metaStorageManager.getLocally(stablePartAssignmentsKey(new
ZonePartitionId(zoneId, p)), revision);
+ Assignments assignments =
+
zoneStableAssignmentsGetLocally(metaStorageManager, new ZonePartitionId(zoneId,
p), revision);
+
+ assert assignments != null
Review Comment:
It's tThe reason why we see null assignments. I can remove it though.
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceUtil.java:
##########
@@ -599,11 +599,37 @@ public static List<Assignments> zoneAssignmentsGetLocally(
) {
return IntStream.range(0, numberOfPartitions)
.mapToObj(p -> {
- Entry e =
metaStorageManager.getLocally(stablePartAssignmentsKey(new
ZonePartitionId(zoneId, p)), revision);
+ Assignments assignments =
+
zoneStableAssignmentsGetLocally(metaStorageManager, new ZonePartitionId(zoneId,
p), revision);
+
+ assert assignments != null
Review Comment:
It's the reason why we see null assignments. I can remove it though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
