sashapolo commented on code in PR #5711:
URL: https://github.com/apache/ignite-3/pull/5711#discussion_r2063834951


##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java:
##########
@@ -734,6 +735,36 @@ public void testNodeStop() throws Exception {
                 .close();
     }
 
+    @Test
+    public void testReplicaStop() throws Exception {
+        startCluster(1);
+
+        Node node = getNode(0);
+
+        String zoneName = "test_zone";
+        int zoneId = createZone(node, zoneName, 1, 1);
+
+        String tableName = "test_table";
+        int tableId = createTable(node, zoneName, tableName);
+        InternalTable internalTable = 
node.tableManager.table(tableId).internalTable();
+
+        var zonePartitionId = new ZonePartitionId(zoneId, 0);
+
+        assertThat(
+                node.partitionReplicaLifecycleManager.stopPartitionInternal(
+                        zonePartitionId,
+                        AFTER_REPLICA_STOPPED,
+                        -1L,
+                        replicaWasStopped -> {}
+                ),
+                willCompleteSuccessfully()
+        );
+
+        // Tables must not be stopped on partition replica stop.
+        verify(internalTable.storage(), never()).close();
+        verify(internalTable.txStateStorage(), never()).close();

Review Comment:
   No, these are not called asynchronously here, because we wait for the future 
above to complete



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to