Re: [PR] IGNITE-24943 Fix table stop on zone replica stop [ignite-3]

[via GitHub]

rpuch commented on code in PR #5711:
URL: https://github.com/apache/ignite-3/pull/5711#discussion_r2063628915


##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItBigZoneOperationTest.java:
##########
@@ -30,7 +30,6 @@
 import org.junit.jupiter.api.extension.ExtendWith;
 
 @WithSystemProperty(key = IgniteSystemProperties.COLOCATION_FEATURE_FLAG, 
value = "true")
-// TODO: https://issues.apache.org/jira/browse/IGNITE-24943 - remove the mute.
 @ExtendWith(FailureManagerExtension.class)
 @MuteFailureManagerLogging

Review Comment:
   Is the mute still needed?



##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1621,10 +1611,12 @@ private void cleanUpTablesResources(Map<Integer, 
TableImpl> tables) {
         }
     }
 
-    private CompletableFuture<Void> tableStopFuture(TableImpl table) {
-        InternalTable internalTable = table.internalTable();
+    private CompletableFuture<Void> stopTableReplicas(TableImpl table) {
+        assert !enabledColocation : "Table replicas should be not stopped in 
colocation mode";

Review Comment:
   ```suggestion
           assert !enabledColocation : "Table replicas should not be stopped in 
colocation mode";
   ```



##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java:
##########
@@ -734,6 +735,36 @@ public void testNodeStop() throws Exception {
                 .close();
     }
 
+    @Test
+    public void testReplicaStop() throws Exception {
+        startCluster(1);
+
+        Node node = getNode(0);
+
+        String zoneName = "test_zone";
+        int zoneId = createZone(node, zoneName, 1, 1);
+
+        String tableName = "test_table";
+        int tableId = createTable(node, zoneName, tableName);
+        InternalTable internalTable = 
node.tableManager.table(tableId).internalTable();
+
+        var zonePartitionId = new ZonePartitionId(zoneId, 0);
+
+        assertThat(
+                node.partitionReplicaLifecycleManager.stopPartitionInternal(
+                        zonePartitionId,
+                        AFTER_REPLICA_STOPPED,
+                        -1L,
+                        replicaWasStopped -> {}
+                ),
+                willCompleteSuccessfully()
+        );
+
+        // Tables must not be stopped on partition replica stop.
+        verify(internalTable.storage(), never()).close();
+        verify(internalTable.txStateStorage(), never()).close();

Review Comment:
   Should there be timeouts? These seem to be called asynchronously



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org