korlov42 commented on code in PR #5674:
URL: https://github.com/apache/ignite-3/pull/5674#discussion_r2063036155
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/fsm/QueryExecutor.java:
##########
@@ -620,4 +622,14 @@ static class ParsedResultWithNextCursorFuture {
this.nextCursorFuture = nextCursorFuture;
}
}
+
+ /**
+ * Dumps component state. This method is used for debugging purposes only.
+ */
+ @TestOnly
+ public void dumpComponentState() {
+ if (executionService instanceof ExecutionServiceImpl) {
+ ((ExecutionServiceImpl<?>) executionService).dumpComponentState();
Review Comment:
query may stuck on OPTIMIZATION or CURSOR_INITIALIZATION phases. Such query
won't be covered by `ExecutionService`. Let's also dump `runningQueries`
collection
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java:
##########
@@ -744,4 +744,10 @@ private void onFail(Throwable err) {
resFut.completeExceptionally(err);
}
}
+
+ @TestOnly
+ @Override
+ public void dumpComponentState() {
+ this.queryProcessor.dumpComponentState();
Review Comment:
Every component must dump its own state only. This line will cause the state
of `queryProcessor` to be dumped twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
