xtern commented on code in PR #5674:
URL: https://github.com/apache/ignite-3/pull/5674#discussion_r2058497452


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImplTest.java:
##########
@@ -768,6 +768,12 @@ public void testDebugInfoFormat() throws 
InterruptedException {
 
         startResponseLatch.await(TIMEOUT_IN_MS, TimeUnit.MILLISECONDS);
 
+        // Wait for all data prefetched to get stable debug info results.

Review Comment:
   I have run the test several times and sometimes it fails
   ```
   Expected: "\nDebug info for query: ExecutionId 
[queryId=3987c944-885b-4d10-870f-5ee749e1af18, executionToken=0] 
(canceled=false, stopped=false)\n  Coordinator node: node_1 (current node)\n  
Root node state: opened\n\n  Fragments awaiting init completion:\n    id=0, 
node=node_1\n    id=1, node=node_1\n    id=1, node=node_2\n    id=1, 
node=node_3\n\n  Local fragments:\n    id=0, state=opened, canceled=false, 
class=Inbox  (root)\n    id=1, state=opened, canceled=false, class=Outbox\n\n  
Fragment#0 tree:\n    class=Inbox, requested=0\n      Remote source: 
nodeName=node_1, state=END\n      Remote source: nodeName=node_2, state=END\n   
   Remote source: nodeName=node_3, state=END\n\n  Fragment#1 tree:\n    
class=Outbox\n      Remote downstream: nodeName=node_1, state=END\n      Source 
#0: class=, requested=0\n\n"
        but: was "\nDebug info for query: ExecutionId 
[queryId=3987c944-885b-4d10-870f-5ee749e1af18, executionToken=0] 
(canceled=false, stopped=false)\n  Coordinator node: node_1 (current node)\n  
Root node state: opened\n\n  Fragments awaiting init completion:\n    id=0, 
node=node_1\n    id=1, node=node_1\n    id=1, node=node_2\n    id=1, 
node=node_3\n\n  Local fragments:\n    id=0, state=opened, canceled=false, 
class=Inbox  (root)\n    id=1, state=opened, canceled=false, class=Outbox\n\n  
Fragment#0 tree:\n    class=Inbox, requested=512\n      Remote source: 
nodeName=node_1, state=WAITING\n      Remote source: nodeName=node_2, 
state=WAITING\n      Remote source: nodeName=node_3, state=WAITING\n\n  
Fragment#1 tree:\n    class=Outbox\n      Remote downstream: nodeName=node_1, 
state=LAST_BATCH\n      Source #0: class=, requested=0\n\n"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to