nizhikov commented on code in PR #12016:
URL: https://github.com/apache/ignite/pull/12016#discussion_r2056117848
##########
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryContext.java:
##########
@@ -576,12 +594,29 @@ else if (cpElement.isFile()) {
* @return Class descriptor.
* @throws BinaryObjectException In case of error.
*/
- @NotNull public BinaryClassDescriptor registerClass(
+ @NotNull BinaryClassDescriptor registerClassEx(
Class<?> cls,
boolean registerMeta,
boolean failIfUnregistered
) throws BinaryObjectException {
- return registerClass(cls, registerMeta, failIfUnregistered, false);
+ return registerClassEx(cls, registerMeta, failIfUnregistered, false);
+ }
+
+ /**
+ * @param cls Class.
+ * @param failIfUnregistered Throw exception if class isn't registered.
+ * @param registerMeta If {@code true}, then metadata will be registered
along with the class descriptor.
+ * @param onlyLocReg {@code true} if descriptor need to register only
locally when registration is required at all.
+ * @return Class descriptor ID.
+ * @throws BinaryObjectException In case of error.
+ */
+ public int registerClass(
Review Comment:
Let's remove `onlyLocReg` parameter as it always `true` and rename
registerClass -> registerClassLocally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
