nizhikov commented on code in PR #12016:
URL: https://github.com/apache/ignite/pull/12016#discussion_r2056116785
##########
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryContext.java:
##########
@@ -566,6 +566,24 @@ else if (cpElement.isFile()) {
return clsNames;
}
+ /**
+ * Attempts registration of the provided class. If the type is already
registered, then an existing descriptor is
+ * returned.
+ *
+ * @param cls Class to register.
+ * @param registerMeta If {@code true}, then metadata will be registered
along with the class descriptor.
+ * @param failIfUnregistered Throw exception if class isn't registered.
+ * @return Class descriptor ID.
+ * @throws BinaryObjectException In case of error.
+ */
+ public int registerClass(
Review Comment:
Let's rename new public methods to `registerType` and keep `registrerClass`
for existing methods that becomes package private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
