timoninmaxim commented on code in PR #12019:
URL: https://github.com/apache/ignite/pull/12019#discussion_r2052732284
##########
modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryMemoryAllocator.java:
##########
@@ -19,22 +19,17 @@
import java.util.ArrayDeque;
import java.util.Arrays;
-import org.apache.ignite.IgniteSystemProperties;
import org.apache.ignite.internal.util.typedef.internal.U;
import static
org.apache.ignite.IgniteSystemProperties.IGNITE_MARSHAL_BUFFERS_PER_THREAD_POOL_SIZE;
import static
org.apache.ignite.IgniteSystemProperties.IGNITE_MARSHAL_BUFFERS_RECHECK;
+import static
org.apache.ignite.internal.binary.streams.BinaryMemoryAllocatorChunk.DFLT_MARSHAL_BUFFERS_PER_THREAD_POOL_SIZE;
+import static
org.apache.ignite.internal.binary.streams.BinaryMemoryAllocatorChunk.DFLT_MARSHAL_BUFFERS_RECHECK;
/**
* On-heap memory allocator.
*/
-public abstract class BinaryMemoryAllocator {
- /** @see IgniteSystemProperties#IGNITE_MARSHAL_BUFFERS_RECHECK */
- public static final int DFLT_MARSHAL_BUFFERS_RECHECK = 10000;
Review Comment:
What is a reason to move this fields? Variables moved to another class that
is still within internal package. Also THREAD_LOCAL variable in this class is
still public and used in BinaryStreams.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
