timoninmaxim commented on code in PR #12019: URL: https://github.com/apache/ignite/pull/12019#discussion_r2052690944
########## modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.binary.streams; + +import java.nio.ByteBuffer; + +/** + * Utility class to provide static methods to create {@link BinaryInputStream} or {@link BinaryOutputStream} in different modes. + */ +public class BinaryStreams { + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @param pos Position. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data, int pos) { + return BinaryHeapInputStream.create(data, pos); + } + + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data) { + return new BinaryHeapInputStream(data); + } + + /** + * @param cap Capacity. Review Comment: Missed disableAutoClose param doc ########## modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.binary.streams; + +import java.nio.ByteBuffer; + +/** + * Utility class to provide static methods to create {@link BinaryInputStream} or {@link BinaryOutputStream} in different modes. + */ +public class BinaryStreams { + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @param pos Position. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data, int pos) { + return BinaryHeapInputStream.create(data, pos); + } + + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data) { + return new BinaryHeapInputStream(data); + } + + /** + * @param cap Capacity. + * @return Binary output stream data. + */ + public static BinaryOutputStream createPooledHeapOutputStream(int cap, boolean disableAutoClose) { + return new BinaryHeapOutputStream(cap, BinaryMemoryAllocator.POOLED.chunk(), disableAutoClose); + } + + /** + * @param cap Capacity. + * @return Binary output stream data. + */ + public static BinaryOutputStream createThreadLocalHeapOutputStream(int cap) { Review Comment: just `createHeapOutputStream` ########## modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.binary.streams; + +import java.nio.ByteBuffer; + +/** + * Utility class to provide static methods to create {@link BinaryInputStream} or {@link BinaryOutputStream} in different modes. + */ +public class BinaryStreams { + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @param pos Position. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data, int pos) { + return BinaryHeapInputStream.create(data, pos); + } + + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data) { + return new BinaryHeapInputStream(data); + } + + /** + * @param cap Capacity. + * @return Binary output stream data. + */ + public static BinaryOutputStream createPooledHeapOutputStream(int cap, boolean disableAutoClose) { + return new BinaryHeapOutputStream(cap, BinaryMemoryAllocator.POOLED.chunk(), disableAutoClose); + } + + /** + * @param cap Capacity. + * @return Binary output stream data. + */ + public static BinaryOutputStream createThreadLocalHeapOutputStream(int cap) { + return new BinaryHeapOutputStream(cap); + } + + /** + * @param cap Capacity. + * @param chunk Memory allocator chunk. + * @return Binary output stream. + */ + public static BinaryOutputStream createHeapOutputStream(int cap, BinaryMemoryAllocatorChunk chunk) { + return new BinaryHeapOutputStream(cap, chunk); + } + + /** + * @param buf Buffer to wrap. + * @return Stream. + */ + public static BinaryInputStream createInputStream(ByteBuffer buf) { + return new BinaryByteBufferInputStream(buf); + } + + /** + * @param ptr Pointer. + * @param cap Capacity. + * @param forceHeap If {@code true} method {@link BinaryInputStream#offheapPointer()} returns 0 and unmarshalling will + * create heap-based objects. + * @return Stream. + */ + public static BinaryInputStream createOffheapInputStream(long ptr, int cap, boolean forceHeap) { + return new BinaryOffheapInputStream(ptr, cap, forceHeap); + } + + /** + * @param ptr Pointer. + * @param cap Capacity. + * @return Stream. + */ + public static BinaryInputStream createOffheapInputStream(long ptr, int cap) { + return new BinaryOffheapInputStream(ptr, cap); + } + + /** + * @return Review Comment: Missed docs ########## modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.binary.streams; + +import java.nio.ByteBuffer; + +/** + * Utility class to provide static methods to create {@link BinaryInputStream} or {@link BinaryOutputStream} in different modes. + */ +public class BinaryStreams { + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @param pos Position. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data, int pos) { + return BinaryHeapInputStream.create(data, pos); + } + + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data) { Review Comment: `createInputStream` ########## modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.binary.streams; + +import java.nio.ByteBuffer; + +/** + * Utility class to provide static methods to create {@link BinaryInputStream} or {@link BinaryOutputStream} in different modes. + */ +public class BinaryStreams { + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @param pos Position. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data, int pos) { Review Comment: `createInputStream` ########## modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.binary.streams; + +import java.nio.ByteBuffer; + +/** + * Utility class to provide static methods to create {@link BinaryInputStream} or {@link BinaryOutputStream} in different modes. + */ +public class BinaryStreams { + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @param pos Position. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data, int pos) { + return BinaryHeapInputStream.create(data, pos); + } + + /** + * Create stream with pointer set at the given position. + * + * @param data Data. + * @return Stream. + */ + public static BinaryInputStream createHeapInputStream(byte[] data) { + return new BinaryHeapInputStream(data); + } + + /** + * @param cap Capacity. + * @return Binary output stream data. + */ + public static BinaryOutputStream createPooledHeapOutputStream(int cap, boolean disableAutoClose) { + return new BinaryHeapOutputStream(cap, BinaryMemoryAllocator.POOLED.chunk(), disableAutoClose); + } + + /** + * @param cap Capacity. + * @return Binary output stream data. + */ + public static BinaryOutputStream createThreadLocalHeapOutputStream(int cap) { + return new BinaryHeapOutputStream(cap); + } + + /** + * @param cap Capacity. + * @param chunk Memory allocator chunk. + * @return Binary output stream. + */ + public static BinaryOutputStream createHeapOutputStream(int cap, BinaryMemoryAllocatorChunk chunk) { Review Comment: `createOutputStream` ########## modules/core/src/main/java/org/apache/ignite/internal/binary/streams/BinaryMemoryAllocator.java: ########## @@ -19,22 +19,17 @@ import java.util.ArrayDeque; import java.util.Arrays; -import org.apache.ignite.IgniteSystemProperties; import org.apache.ignite.internal.util.typedef.internal.U; import static org.apache.ignite.IgniteSystemProperties.IGNITE_MARSHAL_BUFFERS_PER_THREAD_POOL_SIZE; import static org.apache.ignite.IgniteSystemProperties.IGNITE_MARSHAL_BUFFERS_RECHECK; +import static org.apache.ignite.internal.binary.streams.BinaryMemoryAllocatorChunk.DFLT_MARSHAL_BUFFERS_PER_THREAD_POOL_SIZE; +import static org.apache.ignite.internal.binary.streams.BinaryMemoryAllocatorChunk.DFLT_MARSHAL_BUFFERS_RECHECK; /** * On-heap memory allocator. */ -public abstract class BinaryMemoryAllocator { - /** @see IgniteSystemProperties#IGNITE_MARSHAL_BUFFERS_RECHECK */ - public static final int DFLT_MARSHAL_BUFFERS_RECHECK = 10000; Review Comment: What is a reason to move this fields? Variables moved to another class that is still within internal package. Also THREAD_LOCAL variable in this class is still public and used in BinaryStreams. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
