rpuch commented on code in PR #5523:
URL: https://github.com/apache/ignite-3/pull/5523#discussion_r2035542219
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/CatalogVersionSufficiency.java:
##########
@@ -35,6 +35,6 @@ private CatalogVersionSufficiency() {
* @return {@code true} iff the local Catalog version is sufficient.
*/
public static boolean isMetadataAvailableFor(int requiredCatalogVersion,
CatalogService catalogService) {
- return requiredCatalogVersion <= catalogService.latestCatalogVersion();
+ return
catalogService.catalogReadyFuture(requiredCatalogVersion).isDone();
Review Comment:
Probably it makes sense to just reuse the method here
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/CatalogVersionSufficiency.java:
##########
@@ -35,6 +35,6 @@ private CatalogVersionSufficiency() {
* @return {@code true} iff the local Catalog version is sufficient.
*/
public static boolean isMetadataAvailableFor(int requiredCatalogVersion,
CatalogService catalogService) {
- return requiredCatalogVersion <= catalogService.latestCatalogVersion();
+ return
catalogService.catalogReadyFuture(requiredCatalogVersion).isDone();
Review Comment:
Probably it makes sense to just reuse the method there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
