rpuch commented on code in PR #5523:
URL: https://github.com/apache/ignite-3/pull/5523#discussion_r2035530936
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildController.java:
##########
@@ -368,21 +381,22 @@ private void tryScheduleBuildIndex(
ReplicationGroupId primaryReplicaId,
CatalogIndexDescriptor indexDescriptor,
MvTableStorage mvTableStorage,
- ReplicaMeta replicaMeta
+ ReplicaMeta replicaMeta,
+ HybridTimestamp buildAttemptTimestamp
) {
// TODO https://issues.apache.org/jira/browse/IGNITE-22522
// Remove TablePartitionId check.
assert primaryReplicaId instanceof ZonePartitionId
? ((ZonePartitionId) primaryReplicaId).zoneId() == zoneId
- && ((ZonePartitionId) primaryReplicaId).partitionId()
== partitionId
+ && ((ZonePartitionId) primaryReplicaId).partitionId() ==
partitionId
Review Comment:
Here, the line is outdented, but a similar line (2 lines below) is not. It
looks like an inconsistency
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/schema/CatalogVersionSufficiency.java:
##########
@@ -35,6 +35,6 @@ private CatalogVersionSufficiency() {
* @return {@code true} iff the local Catalog version is sufficient.
*/
public static boolean isMetadataAvailableFor(int requiredCatalogVersion,
CatalogService catalogService) {
- return requiredCatalogVersion <= catalogService.latestCatalogVersion();
+ return
catalogService.catalogReadyFuture(requiredCatalogVersion).isDone();
Review Comment:
Could you please make an analogous change in
`IncomingSnapshotCopier#metadataIsSufficientlyComplete()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
