zstan commented on code in PR #5479:
URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2015661860


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/LogicalRelImplementor.java:
##########
@@ -1158,4 +1144,20 @@ private static boolean canFuseProjectionInto(RelNode 
rel) {
 
         return joinProjection;
     }
+
+    private long validateAndGetFetchOffsetParams(RexNode node, String op) {

Review Comment:
   probably we can move this check into Node code and append additional tests 
if it helpful with another issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to