vldpyatkov commented on code in PR #5477:
URL: https://github.com/apache/ignite-3/pull/5477#discussion_r2014423682
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -1327,29 +1313,31 @@ private void initPools(final NodeOptions opts) {
opts.setRaftMetrics(new RaftMetricSource(opts.getStripes(),
opts.getLogStripesCount()));
}
- if (opts.getfSMCallerExecutorDisruptor() == null) {
- opts.setfSMCallerExecutorDisruptor(new
StripedDisruptor<FSMCallerImpl.ApplyTask>(
- opts.getServerName(),
- "JRaft-FSMCaller-Disruptor",
- (nodeName, stripeName) -> IgniteThreadFactory.create(nodeName,
stripeName, true, LOG, STORAGE_READ, STORAGE_WRITE),
- opts.getRaftOptions().getDisruptorBufferSize(),
- () -> new FSMCallerImpl.ApplyTask(),
- opts.getStripes(),
- false,
- false,
-
opts.getRaftMetrics().disruptorMetrics("raft.fsmcaller.disruptor")
- ));
- } else if (ownFsmCallerExecutorDisruptorConfig != null) {
+ if (opts.isSystemGroup()) {
opts.setfSMCallerExecutorDisruptor(new
StripedDisruptor<FSMCallerImpl.ApplyTask>(
opts.getServerName(),
- "JRaft-FSMCaller-Disruptor-" +
ownFsmCallerExecutorDisruptorConfig.getThreadPostfix(),
+ "JRaft-FSMCaller-Disruptor-" + groupId,
opts.getRaftOptions().getDisruptorBufferSize(),
() -> new FSMCallerImpl.ApplyTask(),
- ownFsmCallerExecutorDisruptorConfig.getStripes(),
+ 1,
Review Comment:
I do not see a reason to set more than 1 in case we are initialize the
exclusive disruptor for a RAFT group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
