alievmirza commented on code in PR #5468: URL: https://github.com/apache/ignite-3/pull/5468#discussion_r2012307268
########## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/ZoneRebalanceRaftGroupEventsListener.java: ########## @@ -597,6 +597,9 @@ public static CompletableFuture<Void> handleReduceChanged( ByteArray changeTriggerKey = ZoneRebalanceUtil.pendingChangeTriggerKey(partId); byte[] rev = ByteUtils.longToBytesKeepingOrder(entry.revision()); + ByteArray changeTimestampKey = ZoneRebalanceUtil.pendingChangeTriggerKey(partId); Review Comment: why do you need *changeTimestampKey* and why do you need further changes like this ``` Condition changeRevisionAndTimestampDontExistOrLessThan = and( or(notExists(changeTriggerKey), value(changeTriggerKey).lt(rev)), or(notExists(changeTimestampKey), value(changeTimestampKey).lt(timestamp)) ); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org