ibessonov commented on code in PR #5468:
URL: https://github.com/apache/ignite-3/pull/5468#discussion_r2011912815
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceMinimumRequiredTimeProviderImpl.java:
##########
@@ -172,9 +156,9 @@ Map<Integer, NavigableMap<Long, CatalogZoneDescriptor>>
allZonesByTimestamp(
NavigableMap<Long, CatalogZoneDescriptor> map =
allZones.computeIfAbsent(zone.id(), id -> new TreeMap<>());
if (map.isEmpty() ||
updateRequiresAssignmentsRecalculation(map.lastEntry().getValue(), zone)) {
- map.put(catalog.time(), zone);
+ map.put(zone.updateTimestamp().longValue(), zone);
Review Comment:
Can we use `HybridTimestamp` here for keys? This will make code more
readable. This class is `Comparable`, so no worries about that. Please update
all the usages of `Long` instead of `HybridTimestamp`, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
