timoninmaxim commented on code in PR #11855:
URL: https://github.com/apache/ignite/pull/11855#discussion_r2005987994
##########
modules/core/src/test/java/org/apache/ignite/client/ReliabilityTest.java:
##########
@@ -265,25 +265,45 @@ public void testRetryReadPolicyRetriesCacheGet() {
}
/**
- * Tests retry policy exception handling.
+ * Tests that retry policy exception handling for async operations
propagates to the caller.
*/
@Test
- public void testExceptionInRetryPolicyPropagatesToCaller() {
+ public void testExceptionInRetryPolicyPropagatesToCallerAsync() {
Assume.assumeFalse(partitionAware);
try (LocalIgniteCluster cluster = LocalIgniteCluster.start(1);
IgniteClient client =
Ignition.startClient(getClientConfiguration()
.setRetryPolicy(new ExceptionRetryPolicy())
- .setAddresses(F.first(cluster.clientAddresses()),
F.first(cluster.clientAddresses()))
+ .setAddresses(F.first(cluster.clientAddresses()))
.setClusterDiscoveryEnabled(false))
) {
ClientCache<Integer, Integer> cache = client.createCache("cache");
+
dropAllThinClientConnections(Ignition.allGrids().get(0));
- Throwable asyncEx = GridTestUtils.assertThrows(null, () ->
cache.getAsync(0).get(),
- ExecutionException.class, "Channel is closed");
+ Throwable asyncEx = GridTestUtils.assertThrows(null,
+ () -> cache.getAsync(0).get(),
+ ExecutionException.class, "Channel is closed");
GridTestUtils.assertContains(null, asyncEx.getMessage(),
F.first(cluster.clientAddresses()));
+ }
+ }
+
Review Comment:
Excess white line
##########
modules/core/src/test/java/org/apache/ignite/client/ReliabilityTest.java:
##########
@@ -265,25 +265,45 @@ public void testRetryReadPolicyRetriesCacheGet() {
}
/**
- * Tests retry policy exception handling.
+ * Tests that retry policy exception handling for async operations
propagates to the caller.
*/
@Test
- public void testExceptionInRetryPolicyPropagatesToCaller() {
+ public void testExceptionInRetryPolicyPropagatesToCallerAsync() {
Assume.assumeFalse(partitionAware);
try (LocalIgniteCluster cluster = LocalIgniteCluster.start(1);
IgniteClient client =
Ignition.startClient(getClientConfiguration()
.setRetryPolicy(new ExceptionRetryPolicy())
- .setAddresses(F.first(cluster.clientAddresses()),
F.first(cluster.clientAddresses()))
+ .setAddresses(F.first(cluster.clientAddresses()))
.setClusterDiscoveryEnabled(false))
) {
ClientCache<Integer, Integer> cache = client.createCache("cache");
+
dropAllThinClientConnections(Ignition.allGrids().get(0));
- Throwable asyncEx = GridTestUtils.assertThrows(null, () ->
cache.getAsync(0).get(),
- ExecutionException.class, "Channel is closed");
+ Throwable asyncEx = GridTestUtils.assertThrows(null,
Review Comment:
No changes in this lines
##########
modules/core/src/test/java/org/apache/ignite/client/ReliabilityTest.java:
##########
@@ -265,25 +265,45 @@ public void testRetryReadPolicyRetriesCacheGet() {
}
/**
- * Tests retry policy exception handling.
+ * Tests that retry policy exception handling for async operations
propagates to the caller.
*/
@Test
- public void testExceptionInRetryPolicyPropagatesToCaller() {
+ public void testExceptionInRetryPolicyPropagatesToCallerAsync() {
Review Comment:
use async test param instead
##########
modules/core/src/test/java/org/apache/ignite/internal/client/thin/ReliableChannelTest.java:
##########
@@ -132,16 +132,19 @@ private Set<String> usedDefaultChannels(String... addrs) {
* Checks that reinitialization of duplicated address is correct.
*/
@Test
- public void testReinitDuplicatedAddress() {
+ public void testReinitDuplicatedAddressMerging() {
Review Comment:
Let's not rename test to keep test history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
