Re: [PR] IGNITE-23856 Ignite Thin Client channels unwanted duplication [ignite]

[via GitHub]

FewJuho commented on code in PR #11855:
URL: https://github.com/apache/ignite/pull/11855#discussion_r1967619468


##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java:
##########
@@ -656,14 +657,16 @@ synchronized void initChannelHolders() {
                 for (InetSocketAddress addr : h.getAddresses()) {
                     // If new endpoints contain at least one of channel 
addresses, don't close this channel.
                     if (newAddrsSet.contains(addr)) {
-                        ClientChannelHolder oldHld = 
curAddrs.putIfAbsent(addr, h);
-
-                        if (oldHld == null || oldHld == h) // If not duplicate.
-                            found = true;
+                        found = true;
+                        break;
                     }
                 }
 
-                if (!found)
+                if (found) {
+                    for (InetSocketAddress addr : h.getAddresses())
+                        curAddrs.putIfAbsent(addr, h);

Review Comment:
   These holders are absent in case clientCfg.getAddressesFinder() != null
   Is it worth checking this way?
   ![Screenshot from 2025-02-24 
16-13-02](https://github.com/user-attachments/assets/0b6e6a90-7b16-4401-8930-dce8f0521dea)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org