ivanzlenko commented on code in PR #5431:
URL: https://github.com/apache/ignite-3/pull/5431#discussion_r2002640486
##########
modules/index/src/main/java/org/apache/ignite/internal/index/ChangeIndexStatusTaskController.java:
##########
@@ -241,4 +304,39 @@ private static IntArrayList
getTableIdsForPrimaryReplicaElected(
return tableIds;
}
+
+ private static List<Integer> getZoneIdsForPrimaryReplicaElected(
+ PartitionGroupId partitionGroupId,
+ IntPredicate predicate
Review Comment:
Make no sense to pass IntPredicate here
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -522,9 +522,6 @@ public RaftCommandRunner raftClient() {
}
private CompletableFuture<?> processRequest(ReplicaRequest request,
ReplicaPrimacy replicaPrimacy, UUID senderId) {
Review Comment:
The same about todo
##########
modules/index/src/main/java/org/apache/ignite/internal/index/ChangeIndexStatusTaskScheduler.java:
##########
@@ -102,7 +102,7 @@ public void close() throws Exception {
* Schedules a task for that will transfer the given index to the {@link
CatalogIndexStatus#BUILDING} state.
*/
void scheduleStartBuildingTask(CatalogIndexDescriptor indexDescriptor) {
- assert indexDescriptor.status() == CatalogIndexStatus.REGISTERED;
+ assert indexDescriptor.status() == CatalogIndexStatus.REGISTERED :
indexDescriptor;
Review Comment:
Please add relevant message
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZonePartitionReplicaListener.java:
##########
@@ -241,17 +241,9 @@ private CompletableFuture<ReplicaResult>
processTableAwareRequest(
*
* @param request Request to be processed.
* @param replicaPrimacy Replica primacy information.
- * @param senderId Node sender id.
* @return Future with the result of the processing.
*/
- private CompletableFuture<?> processZoneReplicaRequest(
- ReplicaRequest request,
- ReplicaPrimacy replicaPrimacy,
- UUID senderId
- ) {
- // TODO https://issues.apache.org/jira/browse/IGNITE-24526
- // Need to move the necessary part of
PartitionReplicaListener#processRequest request processing here
-
+ private CompletableFuture<?> processZoneReplicaRequest(ReplicaRequest
request, ReplicaPrimacy replicaPrimacy) {
Review Comment:
Why todo was removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
