rpuch commented on code in PR #5431:
URL: https://github.com/apache/ignite-3/pull/5431#discussion_r2002660875


##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ZonePartitionReplicaListener.java:
##########
@@ -241,17 +241,9 @@ private CompletableFuture<ReplicaResult> 
processTableAwareRequest(
      *
      * @param request Request to be processed.
      * @param replicaPrimacy Replica primacy information.
-     * @param senderId Node sender id.
      * @return Future with the result of the processing.
      */
-    private CompletableFuture<?> processZoneReplicaRequest(
-            ReplicaRequest request,
-            ReplicaPrimacy replicaPrimacy,
-            UUID senderId
-    ) {
-        // TODO https://issues.apache.org/jira/browse/IGNITE-24526
-        // Need to move the necessary part of 
PartitionReplicaListener#processRequest request processing here
-
+    private CompletableFuture<?> processZoneReplicaRequest(ReplicaRequest 
request, ReplicaPrimacy replicaPrimacy) {

Review Comment:
   The corresponding issue is not relevant anymore and will be closed after 
this PR is merged. I just don't want to create a whole separate PR just for 
removal of these TODOs, so I included it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to