sashapolo commented on code in PR #5384:
URL: https://github.com/apache/ignite-3/pull/5384#discussion_r1988662447
##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##########
@@ -898,6 +899,15 @@ void testRebalanceRetryDelayConfiguration() throws
Exception {
assertThat(updateRebalanceRetryDelay(configuration, -1),
willThrowWithCauseOrSuppressed(ConfigurationValidationException.class));
}
+ @Test
+ void testCompatibilityPropertyNameRebalanceRetryDelayMsNameWasNotChanged()
{
Review Comment:
This should be put in a unit test, not inside an integration test
##########
modules/configuration-system/src/testFixtures/java/org/apache/ignite/internal/configuration/utils/SystemConfigurationPropertyCompatibilityChecker.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.configuration.utils;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/**
+ * Class of checkers for possible system configuration properties
compatibility issues. It should help if e.g. a property name was silently
+ * changed in code, but internal documentation changes were omitted.
+ */
+public final class SystemConfigurationPropertyCompatibilityChecker {
+ /**
+ * Asserts that the system configuration property that is declared as
given constant field name wasn't changed.
+ *
+ * @param propertyConstantFieldName The property's constant field name to
address if check failed.
+ * @param propertyExpectedValue The property's expected value.
+ * @param propertyActualValue The actual value via passing the constant
field there.
Review Comment:
```suggestion
* @param propertyActualValue The property's actual value.
```
##########
modules/transactions/src/test/java/org/apache/ignite/internal/tx/HeapLockManagerTest.java:
##########
@@ -133,4 +135,13 @@ public void testNonDefaultConfiguration(
assertThat(lockManager.available(), is(42));
assertThat(lockManager.getSlots(), is(arrayWithSize(0)));
}
+
+ @Test
+ public void test() {
Review Comment:
please rename the test method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
